Your "Style"

[Bobby Hensley]

Everybody has their own style of programming. Details from variable naming convention to function naming to OOP vs. Imperative, etc. One could say it's what makes each of us unique from one another.

So here's the trial. Write your own version of a simple hit counter. This isn't a test to see who's works better or anything remotely close to that. It's just a simple thirty second script that provokes various areas that show off your programming style.

Here's mine:

<?php

class Counter
{
    protected $num_hits;
    protected $hits_file;
    
    /**
     * Assign the properties and increment the count
     *
     * @param    string    File to store hit count
    **/
    public function __construct ($file_name)
    {
        if (!empty ($file_name))
            $this -> hits_file = $file_name;
            
        $this -> num_hits = $this -> get_current_count () + 1;
        $this -> update_count ();
   }
    
    /**
     * Grab the current hit count
     *
     * @return    function call    Hit file doesn't exist
     * @return    integer    Count property is already set
     * @return    integer    Count isn't set, get it from the file
    **/
    public function get_current_count ()
    {
        if (!file_exists ($this -> hits_file))
            return $this -> update_count;
            
        if (isset ($this -> num_hits))
            return $this -> num_hits;

        return file_get_contents ($this -> hits_file);
    }
    
    /**
    * Update the hit count file
    *
    * @return    integer   Boot back 1 incase get_current_count () called us
   **/
    private function update_count ()
    {
        $count_handle = fopen ($this -> hits_file, "w+");
        fwrite ($count_handle, $this -> num_hits);
        fclose ($count_handle);
        
        return 1;
    }
}

$count = new Counter ("counter.dat");
echo $count -> get_current_count ();

?>

Now note that if I was actually to use the above, I wouldn't comment it so heavily unless I was releasing it. But on actual projects that's exactly what I'll do in terms of commenting. Though for larger classes I tend to make just a single, very large comment at the top defining everything in the file.

[Blind]

Commented it so that any one can learn from this

<?php
/* This is flat file so we need to add the txt file the hits are saved in to a variable.
Variable name is storage, but of course you can call it anything you like.
hit.txt = 0, empty file untill the code registers new hits */
$storage = 'hit.txt';

/* Just uses an IF statemtn to make sure we are aloud to write to this file
If not we may need to CCHMOD it
Using PHP built in functions "is_writable" */
if (!is_writable($storage)) die('This file is not writable, you may want to fix this');

/* Again using 2 built in php functions
trim() is used to remove all white spaces. There is ltrim() and rtrim() which can be used to remove white spaces from the start or end of a string
We then use another built in function "file_get_contents" which reads any file into a string.
The +1 at the end is telling PHP to add another entry into the storage file */
$hits = trim(file_get_contents($storage)) + 1;

/* Again another built in function.
fwrite() is used to write the contents of a string
fopen() is used to open and bind a file
w is the mode for fopen, w stands for write() */
fwrite(fopen($storage, 'w'), $hits);

/* And this will just display the amount of hits on the page.
You can use echo or print for this  */
print $hits;
?>

There are many ways of creating something like this.
Flat files is generally a widely used method of doing so instead of MySQL.
I wouldn't say this is the best way of creating a hit counter, but it is an easy and quick method.

And i wouldn't' normally comment a script at all, like this.
If i am doing a large project i normally have a large comment block at the top of each page.

[xcessive]

I never comment any code and i hate OOP, love precedureal... damn classes and types.

[iDesign]

Here's my style.
xD

[DBuzzin]

lol at iDesign

you guys ar making me want to get back into php, ive only got back into javascript this past week and im feeling the love like

[Blind]

Get back into it!

[echnaret]

I haven't looked at anyone elses, I'll go back and do that after I write this.

Hmm, based on the stuff I use, I'd do something like this (not sure if it has bugs or not, I haven't actually tested it):

database.php

<?php

/* Class that deals with all
* Database connections
*/
class Database {
protected $connection;

/* Connect to Database
* (CONSTANT VARIABLES would be
* stored in a separate file and
* have been omitted for this
* example)
*/
function __construct() {
$this->connection = mysql_connect(MYSQL_SERVER, MYSQL_USER, MYSQL_PASSWORD or die(mysql_error());
mysql_select_db(MYSQL_DB_NAME, $this->connection) or die(mysql_error());
}

/* Get the current number of hits from
* a table with two fields, "key" and
* "value"
*/
function get_number_hits() {
$query = "SELECT value FROM ".TABLE_VARIABLES." WHERE key = 'number_hits'";
$result = mysql_fetch_assoc(mysql_query($query));
return $result['value'];
}

/* Increment the number of
* hits by 1
*/
function add_hit() {
$query = "UPDATE ".TABLE_VARIABLES." SET value = value+1 WHERE key = 'number_hits'";
return mysql_query($query);
}

$database = new Database();


index.php

<?php
include("database.php");
$database->add_hit();
?>

<html>
<head><title>My Hit Counter Example</title></head>
<body>
<h1>My Hit Counter Example</h1>
<p>Hello there sir, you are visitor number <?php $database->get_number_hits();?>!</p>
</body>
</html>


Yeah, I probably don't technically need two files as this is so simple, but that's the way I've been doing things thus far.

That was kind of fun. We should totally do some more of these..

[robeck]

Nếu một mai Admin em có lỡ...神奈川県　賃貸 Delete rồi File chứa những yêu thương
Đôi mắt biếc Paint đầy nỗi vấn vương 座間市　賃貸 Đừng khóc nữa anh Restore trở lại.
Em giận hờn cưỡi IE chạy mãi 神奈川県　不動産 Anh hoảng hồn lấy Firefox đuổi theo
Đằng xa kia Netscape đá lông nheo エコ住宅　豊田市 Cancel luôn vì em là trên hết.
Em RAM ít nên Run nhiều sẽ mệt リフォーム　豊田市 Anh sẽ làm Physics Memory
Search cùng em trên khắp nẻo đường đi土壁　豊田市 Anh mạnh mẽ nhờ hai RAM cùng Bus. Robeck

[robeck]

ポンプ | グラウトミキサー | パーカッションドリル | 流量計 | 北海道札幌市 | 株式会社大成建機
中古　ボーリングマシン 親切・丁寧・確実
中古　モルタルポンプ 大成建機は建設機械のレンタル・リース及び販売会社です。お客様のニーズに合った機種の選定、親切・丁寧・確実な対応を心がけております。修理、メンテナンスもお気軽にご相談下さい。
中古　パーカッションドリル ボーリング機器専門に取扱いしております！
レンタル取扱商品
ボーリングマシン、モルタルポンプ、グラウトミキサー、パーカッションドリル、流量計などボーリング機器全般を取り扱ってます

[robeck]

アルマイト
アルマイト処理
アルマイト加工